-
-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for multiple service
s inside service_connect_configuration
#123
feat: Add support for multiple service
s inside service_connect_configuration
#123
Conversation
ah shoot - yes, you are correct. the change looks great and is valid, but it is a breaking change. Lets hold on this for the next breaking change |
This PR has been automatically marked as stale because it has been open 30 days |
bad bot |
service
s inside service_connect_configuration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Merging into the wip/v6
branch
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
Add support for multiple services inside service_connect_configuration
Motivation and Context
According to the Documentation of ECS, service_connect_configuration can configure multiple client-server services and hashicorp/aws provider supports for deploying it (as far as I know) after the major version 5.
However this module does not accept the list of Service Connect service objects and that is the issue this PR wants to fix.
Breaking Changes
Yes. Existing
examples/*
cannot plan/apply if this PR is merged.How Has This Been Tested?
examples/*
to demonstrate and validate my change(s)examples/*
projectspre-commit run -a
on my pull request