Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for multiple services inside service_connect_configuration #123

Conversation

saki-engineering
Copy link

@saki-engineering saki-engineering commented Oct 21, 2023

Description

Add support for multiple services inside service_connect_configuration

Motivation and Context

According to the Documentation of ECS, service_connect_configuration can configure multiple client-server services and hashicorp/aws provider supports for deploying it (as far as I know) after the major version 5.

service_connect_configuration supports the following:

  • enabled - (Required) Specifies whether to use Service Connect with this service.
  • log_configuration - (Optional) The log configuration for the container. See below.
  • namespace - (Optional) The namespace name or ARN of the aws_service_discovery_http_namespace for use with Service Connect.
  • service - (Optional) The list of Service Connect service objects. See below.

Quote: https://registry.terraform.io/providers/hashicorp/aws/5.0.0/docs/resources/ecs_service#service_connect_configuration

However this module does not accept the list of Service Connect service objects and that is the issue this PR wants to fix.

Breaking Changes

Yes. Existing examples/* cannot plan/apply if this PR is merged.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@bryantbiggs
Copy link
Member

ah shoot - yes, you are correct. the change looks great and is valid, but it is a breaking change. Lets hold on this for the next breaking change

Copy link

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Nov 30, 2023
@bryantbiggs bryantbiggs added wip and removed stale labels Nov 30, 2023
@bryantbiggs
Copy link
Member

bad bot

@bryantbiggs bryantbiggs added this to the v6.0.0 milestone Feb 12, 2024
@bryantbiggs bryantbiggs changed the title feat: Add support for multiple service inside service_connect_configuration feat: Add support for multiple services inside service_connect_configuration Feb 12, 2024
@bryantbiggs bryantbiggs changed the base branch from master to wip/v6 February 12, 2024 15:46
Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Merging into the wip/v6 branch

@bryantbiggs bryantbiggs merged commit f0a628d into terraform-aws-modules:wip/v6 Feb 12, 2024
2 checks passed
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple Service Connect Configuration Blocks
2 participants