Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing metadata block for launch configuration #1301

Merged
merged 3 commits into from
Apr 19, 2021

Conversation

kamialie
Copy link
Contributor

@kamialie kamialie commented Apr 14, 2021

PR o'clock

Description

resolves #1300

Added metadata_options block in workers.tf, otherwise module wasn't setting any values for that block. README doesn't require changes as it is internal bug.

Checklist

@kamialie kamialie changed the title Metadata block missing fix:Metadata block missing Apr 14, 2021
@kamialie kamialie changed the title fix:Metadata block missing fix: Metadata block missing Apr 14, 2021
@kamialie
Copy link
Contributor Author

not sure about Docs lint, as I haven't introduced any changes there

@kamialie
Copy link
Contributor Author

Updated target branch, thus, rerun check, now everything looks fine

@barryib barryib changed the title fix: Metadata block missing fix: Add mission metadata block for launch configuration Apr 19, 2021
@barryib barryib merged commit fc6852d into terraform-aws-modules:master Apr 19, 2021
@kamialie kamialie changed the title fix: Add mission metadata block for launch configuration fix: Add missing metadata block for launch configuration Apr 25, 2021
barryib pushed a commit to barryib/terraform-aws-eks that referenced this pull request May 20, 2021
bartmanus added a commit to celtra/terraform-aws-eks that referenced this pull request Jun 28, 2022
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metadata options don't seem to work
2 participants