Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing IMDSv2 metadata restrictions for aws launch config #1257

Conversation

alialperak
Copy link

@alialperak alialperak commented Feb 26, 2021

Add Metadata Options for Launch Configuration

Description

This PR resolves issue #1113

Currently metadata options metadata_http_endpoint, metadata_http_tokens and metadata_http_put_response_hop_limit are supported for aws_launch_templates with #938 but not for aws_launch_configuration as it has arrived later to AWS provider on hashicorp/terraform-provider-aws#14637. This PR adds settings for IDMS v2 restrictions to aws_launch_configuration.

Checklist

@alialperak
Copy link
Author

what happened here? @barryib @wise-Kaas
#1301

@kamialie
Copy link
Contributor

@alialperak looks like I missed this PR and issue, wasn't attentive enough😬 Mine was duplicate of yours and looks like now it has been merged, but isn't part of release yet.

@barryib
Copy link
Member

barryib commented May 6, 2021

Sounds like your change has been merged already. Can we close this PR ?

@barryib
Copy link
Member

barryib commented May 6, 2021

Closing this PR because the requested changes are already merged. Feel free to re-open it if needed.

@barryib barryib closed this May 6, 2021
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants