Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master branch commit fdd44c - broken launch configurations for multiple worker node configurations #140

Closed
1 of 4 tasks
mmcaya opened this issue Sep 25, 2018 · 4 comments
Closed
1 of 4 tasks

Comments

@mmcaya
Copy link
Contributor

mmcaya commented Sep 25, 2018

I have issues

@max-rocket-internet
Quick heads-up
This change broke worker launch configurations for multiple worker group configurations:
https://github.com/terraform-aws-modules/terraform-aws-eks/blame/master/workers.tf#L31

* module.eks.aws_launch_configuration.workers[1]: Resource 'aws_iam_instance_profile.workers' not found for variable 'aws_iam_instance_profile.workers.id'
* module.eks.aws_launch_configuration.workers[0]: Resource 'aws_iam_instance_profile.workers' not found for variable 'aws_iam_instance_profile.workers.id'

Previous code had it properly select via the count index

-  iam_instance_profile        = "${aws_iam_instance_profile.workers.id}"
+  iam_instance_profile        = "${element(aws_iam_instance_profile.workers.*.id, count.index)}"

I'm submitting a...

  • bug report
  • feature request
  • support request
  • kudos, thank you, warm fuzzy

What is the current behavior?

If this is a bug, how to reproduce? Please include a code sample if relevvant.

Sample multi worker group config

worker_groups = [
  {
    "name"                 = "green"
    "instance_type"        = "m4.large"
    "asg_desired_capacity" = "0"
    "asg_max_size"         = "0"
    "asg_min_size"         = "0"
  },
  {
    "name"                 = "blue"
    "instance_type"        = "m4.large"
    "asg_desired_capacity" = "2"
    "asg_max_size"         = "2"
    "asg_min_size"         = "2"
  },
]

worker_group_count = "2"

What's the expected behavior?

Are you able to fix this problem and submit a PR? Link here if you have already.

Can submit PR by end of day 9/25 if a fix doesn't make it in

Environment details

  • Affected module version: master
  • OS:
  • Terraform version:

Any other relevant info

@max-rocket-internet
Copy link
Contributor

Thanks! Can you confirm this fixes it? #141

@mmcaya
Copy link
Contributor Author

mmcaya commented Sep 25, 2018

👍 look good from my local testing,

------------------------------------------------------------------------
No changes. Infrastructure is up-to-date.

@max-rocket-internet
Copy link
Contributor

Thanks! My mistake.

@github-actions
Copy link

github-actions bot commented Dec 3, 2022

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants