Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for ERROR: 'aws_iam_instance_profile.workers' not found #141

Merged
merged 1 commit into from
Sep 25, 2018
Merged

Fix for ERROR: 'aws_iam_instance_profile.workers' not found #141

merged 1 commit into from
Sep 25, 2018

Conversation

max-rocket-internet
Copy link
Contributor

I think I made this mistake in my rebase of #131. I was using a new UI tool for interactive rebase 🤨

Copy link
Contributor

@mmcaya mmcaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Local plan/apply with the revert works as expected with multiple worker groups

Copy link
Contributor

@brandonjbjelland brandonjbjelland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@max-rocket-internet max-rocket-internet merged commit 3b546a9 into terraform-aws-modules:master Sep 25, 2018
@max-rocket-internet max-rocket-internet deleted the syntax_fix branch September 25, 2018 20:00
nicgrayson pushed a commit to nicgrayson/terraform-aws-eks that referenced this pull request Oct 29, 2018
* upstream/master: (25 commits)
  Update documentation for removed `configure_kubectl_session` (terraform-aws-modules#171)
  remove the checksum step
  Add target_group_arns to worker ASG (terraform-aws-modules#167)
  Removing 2 providers from the module (terraform-aws-modules#168)
  Removing aws_iam_service_linked_role from module (terraform-aws-modules#160)
  Adjust the order and correct/update the info (terraform-aws-modules#163)
  Ruby ver `2.4.2` -> `2.4.4`
  Move env vars into env section
  Remove `v` in `v0.11.8`
  Better version control
  Add suspended_processes attributes to autoscaling_group (terraform-aws-modules#159)
  Updating changelog for v1.7.0 (terraform-aws-modules#158)
  Revert "Add suspended_processes attributes to autoscaling_group (terraform-aws-modules#153)" (terraform-aws-modules#157)
  Add suspended_processes attributes to autoscaling_group (terraform-aws-modules#153)
  Add option to change worker placement_tenancy. (terraform-aws-modules#142)
  Allowing 443 to nodes from EKS service (terraform-aws-modules#148)
  Fixed issue with 'workers_group_defaults_defaults.iam_role_id' and added explicit depends_on for 'update_config_map_aws_auth' (terraform-aws-modules#147)
  Added timeout configs and variables to aws_eks_cluster resource (terraform-aws-modules#149)
  Fixing travis config (terraform-aws-modules#151)
  Fix for ERROR: 'aws_iam_instance_profile.workers' not found (terraform-aws-modules#141)
  ...
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants