fix: Only include CA thumbprint in OIDC provider list #2769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per terraform-aws-modules#2732 and #32847, only the CA thumbprint should be included in the OIDC provider thumbprint list.
danielfrankcom
force-pushed
the
dev/daniel.frankcom/2732/only-ca-fingerprint
branch
from
e88b0d7 to
691f170
Compare
danielfrankcom
changed the title
This was
linked to
issues
Oct 6, 2023
2 tasks
bryantbiggs
merged commit 7e5de15
into
terraform-aws-modules:master
17 of 18 checks passed
antonbabenko
pushed a commit
that referenced
this pull request
Oct 6, 2023
### [19.17.1](v19.17.0...v19.17.1) (2023-10-06) ### Bug Fixes * Only include CA thumbprint in OIDC provider list ([#2769](#2769)) ([7e5de15](7e5de15)), closes [#2732](#2732) [#32847](https://github.com/terraform-aws-modules/terraform-aws-eks/issues/32847)
|
This PR is included in version 19.17.1 🎉 |
2 tasks
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change modifies the OIDC provider
thumbprint_list, so that it only contains the CA fingerprint, rather than all fingerprints.Motivation and Context
Addresses #2732, by reverting the change from #2307.
According to the description of #2732, #2307 introduced the inclusion of all certificate fingerprints in the
thumbprint_list. Based on a later documentation change in hashicorp/terraform-provider-aws#32847, only the CA fingerprint should be included in thethumbprint_list.From the latest docs, the following should be used:
Breaking Changes
This shouldn't break existing functionality, since the root CA encompasses the authority provided by any other certificates that were previously included.
How Has This Been Tested?
I tested this change by modifying the reproduction code provided in #2768 to reference the modified
eksmodule.Before the change, 4 fingerprints were included for the OIDC provider. After the change, only the single root CA fingerprint was included.
pre-commit run -aon my pull request