Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove python@3.8 deps from macos lint #1073

Closed

Conversation

krrrr38
Copy link
Contributor

@krrrr38 krrrr38 commented Oct 28, 2020

PR o'clock

Description

master branch ci is failed, because of conflict python versions.

To solve it, unlink python@3.8 before install pre-commit which depends on python@3.9.

https://formulae.brew.sh/formula/pre-commit

Checklist

now, pre-commit depends on python@3.9
@krrrr38 krrrr38 force-pushed the no-python38-on-lint branch from 61e8f22 to ac40116 Compare October 28, 2020 22:46
@krrrr38 krrrr38 changed the title ci: remote python@3.8 deps from macos lint ci: remove python@3.8 deps from macos lint Oct 28, 2020
@krrrr38
Copy link
Contributor Author

krrrr38 commented Oct 28, 2020

#1074 approach might be better.

@barryib
Copy link
Member

barryib commented Oct 28, 2020

Closing this in favor of #1074

@barryib barryib closed this Oct 28, 2020
@krrrr38 krrrr38 deleted the no-python38-on-lint branch October 28, 2020 23:58
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants