feat: Launch Template ASGs pin to created version

[lowjoel]

PR o'clock

Description

When creating worker node groups with Launch Templates, the created ASGs currently use $Latest as the version of the Launch Template to start nodes with. When asg_recreate_on_change is false, that's expected, but when asg_recreate_on_change is true, this means that as soon as a new Launch Template is created the old ASGs will start using the new launch template.

This changes the logic to support a $Created value, which would then reference the version created in Terraform. When asg_recreate_on_change is false, the ASG still points to the latest (as soon as Terraform gets to it). When asg_recreate_on_change is true, the older ASGs (when using asg_recreate_on_change would still reference the older LT version, and so compute capacity won't be lost should the new LT have problems spinning up nodes.

Checklist

• CI tests are passing
• README.md has been updated after any changes to variables and outputs. See https://github.com/terraform-aws-modules/terraform-aws-eks/#doc-generation

[lowjoel]

Not sure why docs are failing - let me know if something requires fixing.

[lowjoel]

Hey @barryib @james-callahan - anything I need to do to get a review on this please?

[barryib]

@lowjoel I think this will be solved in #1370. What do you think ?

[lowjoel]

Yeah I think that could work too. It implements the same thing in a different way. If that gets merged I think this one can be closed.

[barryib]

Yeah I think that could work too. It implements the same thing in a different way. If that gets merged I think this one can be closed.

Great. So let close this one. Thanks again for your help.

[barryib]

It's now implemented in #1370

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.