Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: Added variable for not hardcoding root device name in aws node group #1685

Closed

Conversation

alexandrst88
Copy link

PR o'clock

Description

Due to hardcoded device_name https://github.com/terraform-aws-modules/terraform-aws-eks/blob/master/modules/node_groups/launch_template.tf#L41. it's not possible to extend root block device.

Checklist

@daroga0002
Copy link
Contributor

I dont see issue linked to this PR, could you paste a config which is failing and which is solved by this PR?

@alexandrst88
Copy link
Author

I dont see issue linked to this PR, could you paste a config which is failing and which is solved by this PR?

#1686

@alexandrst88 alexandrst88 changed the title improvement: Added variable for not hardcoding root device name in aws node group DRAFT: improvement: Added variable for not hardcoding root device name in aws node group Nov 9, 2021
@alexandrst88 alexandrst88 changed the title DRAFT: improvement: Added variable for not hardcoding root device name in aws node group improvement: Added variable for not hardcoding root device name in aws node group Nov 9, 2021
@stevehipwell
Copy link
Contributor

@alexandrst88 you shouldn't be making changes to locals.tf for a default value in the node groups module. Please take a look at how defaults are set for node group only variables.

@tsurankov
Copy link

@alexandrst88 Any updates on this? I am going to use a custom Ubuntu AMI and have faced the same issue

@antonbabenko
Copy link
Member

This issue has been resolved in version 18.0.0 🎉

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants