Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update documentation related to default EKS node group settings and v18.x security group changes #1760

Merged
merged 2 commits into from
Jan 10, 2022

Conversation

bryantbiggs
Copy link
Member

@bryantbiggs bryantbiggs commented Jan 10, 2022

Description

  • update documentation to correct example usage of default EKS managed node group
    • by default, the module creates a launch template to ensure tags are propagated to instances, etc., so users may need to disable it to use the default template provided by the AWS EKS managed node group service when setting EKS managed node service settings that are not required to be set in a launch template (its a weird/confusing mix but the way the AWS service works today)
  • add a note in the backwards incompatible changes section regarding security groups to ensure users reading the upgrade guide are notified of the security group changes (ref: Cannot create Ingress resources after upgrading to 18 release #1748)
  • update eks-managed-node-group example to correct remote SSH access to use actual key; errors out otherwise

Motivation and Context

Breaking Changes

  • No

How Has This Been Tested?

  • I have tested and validated these changes using one or more of the provided examples/* projects
    - validated with eks-managed-node-group example

@bryantbiggs bryantbiggs changed the title chore: update documentation related to default EKS node group settings and v18.x security group changes chore: Update documentation related to default EKS node group settings and v18.x security group changes Jan 10, 2022
@bryantbiggs bryantbiggs marked this pull request as ready for review January 10, 2022 16:32
@antonbabenko antonbabenko merged commit 7babe87 into terraform-aws-modules:master Jan 10, 2022
@bryantbiggs bryantbiggs deleted the chore/add-docs branch January 10, 2022 16:59
@antonbabenko
Copy link
Member

This PR is included in version 18.0.6 🎉

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The disk_size does not changed. instance t4g not available
2 participants