feat: Support default_tags in aws_autoscaling_group #1973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pulls just the autoscaling_group changes out of #1968 |
bryantbiggs
approved these changes
Mar 28, 2022
There was a problem hiding this comment.
awesome, thank you for the PR! we'll probably make this the default on the next major release but for now its great as is - @antonbabenko 👍🏽
antonbabenko
changed the title
antonbabenko
pushed a commit
that referenced
this pull request
Mar 29, 2022
## [18.16.0](v18.15.0...v18.16.0) (2022-03-29) ### Features * Support default_tags in aws_autoscaling_group ([#1973](#1973)) ([7a9458a](7a9458a))
|
This PR is included in version 18.16.0 🎉 |
spr-mweber3
pushed a commit
to spring-media/terraform-aws-eks
that referenced
this pull request
Apr 26, 2022
spr-mweber3
pushed a commit
to spring-media/terraform-aws-eks
that referenced
this pull request
Apr 26, 2022
## [18.16.0](terraform-aws-modules/terraform-aws-eks@v18.15.0...v18.16.0) (2022-03-29) ### Features * Support default_tags in aws_autoscaling_group ([terraform-aws-modules#1973](terraform-aws-modules#1973)) ([7a9458a](terraform-aws-modules@7a9458a))
it-without-politics
pushed a commit
to it-without-politics/terraform-aws-eks
that referenced
this pull request
May 23, 2022
it-without-politics
pushed a commit
to it-without-politics/terraform-aws-eks
that referenced
this pull request
May 23, 2022
## [18.16.0](terraform-aws-modules/terraform-aws-eks@v18.15.0...v18.16.0) (2022-03-29) ### Features * Support default_tags in aws_autoscaling_group ([terraform-aws-modules#1973](terraform-aws-modules#1973)) ([7a9458a](terraform-aws-modules@7a9458a))
baibailiha
added a commit
to baibailiha/terraform-aws-eks
that referenced
this pull request
Sep 13, 2022
## [18.16.0](terraform-aws-modules/terraform-aws-eks@v18.15.0...v18.16.0) (2022-03-29) ### Features * Support default_tags in aws_autoscaling_group ([#1973](terraform-aws-modules/terraform-aws-eks#1973)) ([ac7fb3c](terraform-aws-modules/terraform-aws-eks@ac7fb3c))
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
use_default_tagsto EKS self managed node group module definition. When set totrue, the default tags configured on the provider will be added to the autoscaling_group tags.var.self_managed_node_groupsorvar.self_managed_node_group_defaultsand pass the result to the self managed node group module.Motivation and Context
Fixes #1916
Breaking Changes
No
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request