-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add optional list of policy ARNs for attachment to Karpenter IRSA #2537
feat: Add optional list of policy ARNs for attachment to Karpenter IRSA #2537
Conversation
Hi @bryantbiggs not sure you are the right person to ask for but could you please review this PR please ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the addition!
## [19.11.0](v19.10.3...v19.11.0) (2023-03-28) ### Features * Add optional list of policy ARNs for attachment to Karpenter IRSA ([#2537](#2537)) ([bd387d6](bd387d6))
This PR is included in version 19.11.0 🎉 |
Thanks for the fix! I was just about to start working on this! |
} | ||
}, | ||
) | ||
fargate_profiles = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bryantbiggs Is it no longer a recommendation to create one Fargate profile per AZ as noted here?
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
This PR addresses the issue (feature request) reported in #2535
Motivation and Context
It adds possibility to attach a custom IAM policy ARN (with access to CMK KMS) to Karpenter IRSA.
At the moment this is not possible. The only way is to add a KMS usage policy to the KMS resource which is inconvenient in our case because it's managed by other team.
We would like to attach a custom IAM policy to the principal, i.e. Karpenter IRSA.
Resolves #2535
Resolves #2540
Breaking Changes
No.
How Has This Been Tested?
examples/*
to demonstrate and validate my change(s)Note: I cannot add an existing managed IAM policy ARN for CMK KMS because Amazon doesn't provide one I could simply reference in examples.
examples/*
projectspre-commit run -a
on my pull requestRan the terraform plan referencing my fork branch with one CMK KMS policy ARN: