Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use coalesce when desired default value is not null #2696

Merged
merged 4 commits into from
Jul 27, 2023
Merged

fix: Use coalesce when desired default value is not null #2696

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
423e398
Change `try` to `coalesce`
Roberdvs Jul 21, 2023
8ffe91c
Keep try function to handle missing map key
Roberdvs Jul 21, 2023
80b95db
Keep try function to handle missing map key
Roberdvs Jul 21, 2023
c445c53
Remove extra parenthesis
Roberdvs Jul 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,7 +386,7 @@ resource "aws_eks_addon" "this" {
cluster_name = aws_eks_cluster.this[0].name
addon_name = try(each.value.name, each.key)

addon_version = try(each.value.addon_version, data.aws_eks_addon_version.this[each.key].version)
addon_version = coalesce(each.value.addon_version, data.aws_eks_addon_version.this[each.key].version)
Roberdvs marked this conversation as resolved.
Show resolved Hide resolved
configuration_values = try(each.value.configuration_values, null)
preserve = try(each.value.preserve, null)
resolve_conflicts = try(each.value.resolve_conflicts, "OVERWRITE")
Expand Down Expand Up @@ -414,7 +414,7 @@ resource "aws_eks_addon" "before_compute" {
cluster_name = aws_eks_cluster.this[0].name
addon_name = try(each.value.name, each.key)

addon_version = try(each.value.addon_version, data.aws_eks_addon_version.this[each.key].version)
addon_version = coalesce(each.value.addon_version, data.aws_eks_addon_version.this[each.key].version)
configuration_values = try(each.value.configuration_values, null)
preserve = try(each.value.preserve, null)
resolve_conflicts = try(each.value.resolve_conflicts, "OVERWRITE")
Expand Down