Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for --enable-docker-bridge #302

Merged
merged 2 commits into from
Mar 13, 2019
Merged

Add support for --enable-docker-bridge #302

merged 2 commits into from
Mar 13, 2019

Conversation

michaelmccord
Copy link
Contributor

@michaelmccord michaelmccord commented Mar 13, 2019 •
edited
Loading

PR o'clock

Description

This enables support for --enable-docker-bridge in the latest eks ami.

Checklist

  • terraform fmt and terraform validate both work from the root and examples/eks_test_fixture directories (look in CI for an example)
  • Tests for the changes have been added and passing (for bug fixes/features) ---- ?
  • Test results are pasted in this PR (in lieu of CI) --- ?
  • I've added my change to CHANGELOG.md
  • Any breaking changes are highlighted above

@RothAndrew
Copy link
Contributor

RothAndrew commented Mar 13, 2019 •
edited
Loading

Sweet jesus this is it! Eureka! We have been bending over backwards trying to figure out what broke our Jenkins jobs that were building docker containers.

awslabs/amazon-eks-ami#183

awslabs/amazon-eks-ami#187

awslabs/amazon-eks-ami#109

max-rocket-internet
max-rocket-internet approved these changes Mar 13, 2019
View reviewed changes
Copy link
Contributor

@max-rocket-internet max-rocket-internet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thanks!

@max-rocket-internet max-rocket-internet merged commit 80085f5 into terraform-aws-modules:master Mar 13, 2019
@max-rocket-internet max-rocket-internet mentioned this pull request Mar 21, 2019
Closed
4 tasks
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@max-rocket-internet max-rocket-internet max-rocket-internet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaelmccord @RothAndrew @max-rocket-internet