feat: Require users to supply OS via ami_type and not via platform which is unable to distinquish between the number of variants supported today
#3068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… which is unable to distinquish between the different variants
antonbabenko
approved these changes
Jun 13, 2024
| # TODO - will be removed in v21.0 | ||
| user_data_type = try(local.ami_type_to_user_data_type[var.ami_type], var.platform) | ||
|
|
||
| user_data_type = local.ami_type_to_user_data_type[var.ami_type] |
There was a problem hiding this comment.
LGTM, but this change is probably "feat" not "fix".
bryantbiggs
changed the title
ami_type and not via platform which is unable to distinquish between the different variantsami_type and not via platform which is unable to distinquish between the number of variants supported today
antonbabenko
pushed a commit
that referenced
this pull request
Jun 13, 2024
## [20.14.0](v20.13.1...v20.14.0) (2024-06-13) ### Features * Require users to supply OS via `ami_type` and not via `platform` which is unable to distinquish between the number of variants supported today ([#3068](#3068)) ([ef657bf](ef657bf))
|
This PR is included in version 20.14.0 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ami_typeand not viaplatformwhich is unable to distinquish between the different variantsMotivation and Context
Breaking Changes
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request