feat: Add support for desired_capacity_type
(named desired_size_type
) on self-managed node group
#3166
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
desired_capacity_type
for theaws_autoscaling_group
resource to AWS default value"units"
Motivation and Context
"units"
on their end, but evidently subsequent runs of Terraform don't see this during a refresh of stateif a user goes into the AWS Console and edits the Autoscaling Group (changes nothing, just clicks the
Save
button), Terraform will suddenly see this attribute when it refreshes state 🤦if this happens, you will have no choice but to destroy the autoscaling group and recreate via the Terraform because without this change there is no way to tell the current module to not try to set the
desired_capacity_type = "units" -> null
Breaking Changes
"units"
is the default valueHow Has This Been Tested?
examples/*
to demonstrate and validate my change(s)examples/*
projectspre-commit run -a
on my pull request