Replacing enable_docker_bridge with a generic option called bootstrap_extra_args

[max-rocket-internet]

Description

Replacing enable_docker_bridge with a generic option called bootstrap_extra_args

Fixes #310 #317

Checklist

• terraform fmt and terraform validate both work from the root and examples/eks_test_fixture directories (look in CI for an example)
• Tests for the changes have been added and passing (for bug fixes/features)
• Test results are pasted in this PR (in lieu of CI)
• I've added my change to CHANGELOG.md
• Any breaking changes are highlighted above

[max-rocket-internet]

Not sure about the no quoting here.

[RothAndrew]

A section should be added to the readme that talks about the enable_docker_bridge flag since it now doesn't have a variable.

[max-rocket-internet]

@RothAndrew OK good idea. I've highlighted it in the changelog in the same way it's been done previously

[RothAndrew]

I was referring more to a section that says something like: "Use the bootstrap_extra_args variable to add other arguments such as the new --enable-docker-bridge flag, which is necessary for functionality like docker-in-docker"

awslabs/amazon-eks-ami#187

[max-rocket-internet]

OK but where do we put that though? Not in the main readme as that is documentation for the module itself, not for random gotchas and issues.

We could create another file in /docs? Or perhaps we create a file /docs/known-issues.md where we could detail this and also all the subnet tagging issues people seem to have?

[max-rocket-internet]

@RothAndrew I will merge this as I've tested it both with and without the docker bridge option and the nodes join the cluster.

If you feel there is some documentation about that issue that is missing then you can make a PR for that 🙂

[RothAndrew]

@max-rocket-internet sorry, this got pushed off my radar.

There could definitely be a troubleshooting or FAQ doc, that's a good idea.

On a more troubling topic, this should have resulted in a major version bump, since it has a breaking change. Recommend immediately releasing a v2.3.2 tag with this change reverted and then releasing v3.0.0.

Without doing that, someone who had the version they are using as ~> 2.3.0, and using enable_docker_bridge will get hosed when their terraform init installs v2.3.1.

Edit: Here's the docs page for module versions.

[max-rocket-internet]

this should have resulted in a major version bump

I think you are right but it's a little late now. I don't want to delete a tag as that is just messy.

Without doing that, someone who had the version they are using as ~> 2.3.0, and using enable_docker_bridge will get hosed

Not exactly. The docker bridge option will stop working ONLY if they update their version of this module without checking what's changed AND if they don't look at what terraform is actually changing.

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.