Revert #631. Add back manage security group flag

[ryanooi]

PR o'clock

Description

Revert #631
Fix #675

Checklist

• Change added to CHANGELOG.md. All changes must be added and breaking changes and highlighted
• CI tests are passing
• README.md has been updated after any changes to variables and outputs. See https://github.com/terraform-aws-modules/terraform-aws-eks/#doc-generation

[russki]

yes please ❤️this makes it possible to provide network access lists to private endpoints again

[barryib]

@rayanooi I'm going to test this to boostrap a fresh new cluster this week.

[russki]

@barryib how did the test go?

[dfredell]

I ran into this issue two weeks ago and found a workaround by using @ryanooi 's branch via
source = "github.com/ryanooi/terraform-aws-eks?ref=857a8dec23884e5c9a16fd7dec7e04b627652784"
in my module elk terraform.

Today I had spun up two clusters from a blank slate with the master branch of ryanooi/terraform-aws-eks successfully.

I did have to have to add cluster_create_security_group

  cluster_security_group_id       = aws_security_group.cluster[0].id
  cluster_create_security_group   = false

[pab1it0]

Got the same issue while creating my own worker security group. @ryanooi's master branch with:

worker_security_group_id     = aws_security_group.worker_node_sg.id
worker_create_security_group = false

Seems to works

[max-rocket-internet]

Thanks @ryanooi 💜

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.