-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New release: v9.0.0 #752
New release: v9.0.0 #752
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments, otherwise LGTM 👍
CHANGELOG.md
Outdated
|
||
- changed timeout for creating EKS (by @confiq) | ||
## [[v9.0.0](https://github.com/terraform-aws-modules/terraform-aws-eks/compare/v8.2.0...v9.0.0)] - 2020-xx-xx] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add release date.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes
CHANGELOG.md
Outdated
## [[v9.0.0](https://github.com/terraform-aws-modules/terraform-aws-eks/compare/v8.2.0...v9.0.0)] - 2020-xx-xx] | ||
|
||
- Revert #631. Add back manage security group flags. (by @ryanooi) | ||
- Changed timeout for creating EKS (by @confiq) | ||
- Added instructions for how to add Windows nodes (by @ivanguravel) | ||
- [CI] Switch `Validate` github action to use env vars (by @max-rocket-internet) | ||
- [CI] Bump pre-commit-terraform version (by @barryib) | ||
- Added example `examples/irsa` for IAM Roles for Service Accounts (by @max-rocket-internet) | ||
- **Breaking:** Removal of autoscaling IAM policy and tags (by @max-rocket-internet) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move breaking changes to the top. In that way, they are more visible.
|
||
- Write your awesome change here (by @you) | ||
|
||
# History |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please remove unnecessary "hisotory" sections from the changelog. https://github.com/terraform-aws-modules/terraform-aws-eks/pull/752/files#diff-4ac32a78649ca5bdd8e0ba38b7006a1eL36 and https://github.com/terraform-aws-modules/terraform-aws-eks/pull/752/files#diff-4ac32a78649ca5bdd8e0ba38b7006a1eL85
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
No description provided.