Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster-autoscaler shouldn't be scheduled on spot #755

Merged
merged 2 commits into from
Mar 4, 2020

Conversation

simowaer
Copy link
Contributor

Update documentation to schedule cluster-autoscaler on normal instances.

PR o'clock

Description

The documentation states the cluster autoscaler should be scheduled on spot instances. This is incorrect. It's the exact opposite.

Update documentation to schedule cluster-autoscaler on normal instances.
Copy link
Member

@barryib barryib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simowaer Thanks. Can you please update the changelog.

@simowaer
Copy link
Contributor Author

simowaer commented Mar 4, 2020

@barryib Thanks. updated.

@barryib barryib merged commit 81ded92 into terraform-aws-modules:master Mar 4, 2020
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants