use correct policy arns for CN regions (cn-north-1, cn-northwest-1)

[cofyc]

PR o'clock

Description

Please explain the changes you made here and link to any relevant issues.

Checklist

• Change added to CHANGELOG.md. All changes must be added and breaking changes and highlighted
• CI tests are passing
• README.md has been updated after any changes to variables and outputs. See https://github.com/terraform-aws-modules/terraform-aws-eks/#doc-generation

[cofyc]

cc @max-rocket-internet
this is the simplest solution I found. data resource aws_iam_policy cannot be used here because it doesn't support getting arn by name.

[max-rocket-internet]

What an annoying issue! But OK, thanks for the fix @cofyc

[alloveras]

What about using aws_partition data resource instead?

data "aws_partition" "current" {}

resource "aws_iam_role_policy_attachment" "workers_AmazonEKSWorkerNodePolicy" {
  count      = var.manage_worker_iam_resources && var.create_eks ? 1 : 0
  policy_arn = "arn:${data.aws_partition.current.partition}:iam::aws:policy/AmazonEKSWorkerNodePolicy"
  role       = aws_iam_role.workers[0].name
}

resource "aws_iam_role_policy_attachment" "workers_AmazonEKS_CNI_Policy" {
  count      = var.manage_worker_iam_resources && var.attach_worker_cni_policy && var.create_eks ? 1 : 0
  policy_arn = "arn:${data.aws_partition.current.partition}:iam::aws:policy/AmazonEKS_CNI_Policy"
}

[cofyc]

ah, this looks perfect! Send a PR for this?

[cofyc]

cc @max-rocket-internet

[alloveras]

Sure, will send a PR shortly 😄

[alloveras]

Here it is: #820

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.