Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not attach force MFA statement for iam-groups-with-policies by default #333

Merged
merged 10 commits into from
Mar 23, 2023
Merged

fix: Do not attach force MFA statement for iam-groups-with-policies by default #333

merged 10 commits into from
Mar 23, 2023

Conversation

enver
Copy link
Contributor

@enver enver commented Jan 31, 2023

Description

Disable MFA enforcement for created groups added in 5.11.0. This change was undocumented, therefore it should be reverted and added as opt-in feature.

Motivation and Context

Keep the module backward compatible with versions prior to 5.11.0

Fixes #332

Breaking Changes

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@github-actions
Copy link

github-actions bot commented Mar 3, 2023

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Mar 3, 2023
@enver
Copy link
Contributor Author

enver commented Mar 3, 2023

@antonbabenko Could you please review

@github-actions github-actions bot removed the stale label Mar 4, 2023
@bravecobra
Copy link

Could someone please take the time to review this fix as it is a blocking upgrade issue.

Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bryantbiggs bryantbiggs merged commit b9f3409 into terraform-aws-modules:master Mar 23, 2023
antonbabenko pushed a commit that referenced this pull request Mar 23, 2023
### [5.14.3](v5.14.2...v5.14.3) (2023-03-23)

### Bug Fixes

* Do not attach force MFA statement for iam-groups-with-policies by default ([#333](#333)) ([b9f3409](b9f3409))
@antonbabenko
Copy link
Member

This PR is included in version 5.14.3 🎉

@enver enver deleted the add-option-to-disable-force-mfa branch March 24, 2023 08:05
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MFA enforced for groups with policies since 5.11.0
4 participants