Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow Change Password when no MFA present #340

Merged

Conversation

0x46616c6b
Copy link
Contributor

@0x46616c6b 0x46616c6b commented Feb 15, 2023

We faced an issue since #313 that new users which need to set a new password after first login not able to do that. Reason was that iam:ChangePassword was not granted for users which not have a MFA device set (which is the case for new users).

With this change we are able to create new users and they can login with there temporary password and are able to reset the password.

Maybe it is related to #333.

@0x46616c6b 0x46616c6b changed the title Allow Change Password when no MFA present fix: Allow Change Password when no MFA present Feb 15, 2023
Copy link
Member

@antonbabenko antonbabenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@antonbabenko antonbabenko merged commit 0c1cfaa into terraform-aws-modules:master Feb 15, 2023
antonbabenko pushed a commit that referenced this pull request Feb 15, 2023
### [5.11.2](v5.11.1...v5.11.2) (2023-02-15)

### Bug Fixes

* Allow Change Password when no MFA present ([#340](#340)) ([0c1cfaa](0c1cfaa))
@antonbabenko
Copy link
Member

This PR is included in version 5.11.2 🎉

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants