Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add cert-manager support to 'iam-role-for-service-accounts-eks' #222

Closed
wants to merge 1 commit into from
Closed

feat: Add cert-manager support to 'iam-role-for-service-accounts-eks' #222

wants to merge 1 commit into from

Conversation

dmitriishaburov
Copy link

Signed-off-by: Dmitrii Shaburov dmitrii.shaburov@bolt.eu

Description

Added policy and attachment for cert-manager DNS01 validation

Motivation and Context

Satisfies #217

Breaking Changes

Does not break backwards compatibility

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request
  • I have tested and validated these changes in internal project

Signed-off-by: Dmitrii Shaburov <dmitrii.shaburov@bolt.eu>
@dmitriishaburov
Copy link
Author

I'm not sure about the naming.
cert-manager is officially named like that, all lowercase with dash, but if I'm using that name in docs/description it looks way too different from other names with Everything Capitalized

@antonbabenko
Copy link
Member

This issue has been resolved in version 4.20.0 🎉

@dmitriishaburov dmitriishaburov deleted the feature-cert-manager branch April 18, 2022 11:45
@github-actions
Copy link

github-actions bot commented Nov 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants