Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add policy_name_prefix for IRSA policies #243

Merged
merged 1 commit into from
May 3, 2022
Merged

feat: Add policy_name_prefix for IRSA policies #243

merged 1 commit into from
May 3, 2022

Conversation

cvockrodt
Copy link
Contributor

@cvockrodt cvockrodt commented May 3, 2022 •
edited by bryantbiggs
Loading

Description

Replace AmazonEKS_ with user provided variable policy_name_prefix which defaults to AmazonEKS_

Motivation and Context

Many organizations have specific naming convention requirements for roles and policies. Allowing for name prefixes means members of those organizations can utilize this module and be compliant.

Closes #239

Breaking Changes

No breaking changes.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@cvockrodt cvockrodt changed the title feat: add policy_name_prefix for IRSA policies feat: Add policy_name_prefix for IRSA policies May 3, 2022
bryantbiggs
bryantbiggs approved these changes May 3, 2022
View reviewed changes
Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @cvockrodt

@bryantbiggs bryantbiggs merged commit d932f65 into terraform-aws-modules:master May 3, 2022
antonbabenko pushed a commit that referenced this pull request May 3, 2022
@semantic-release-bot
chore(release): version 4.24.0 [skip ci]
8eb4ed8 
## [4.24.0](v4.23.0...v4.24.0) (2022-05-03)

### Features

* add policy_name_prefix for IRSA policies ([#243](#243)) ([d932f65](d932f65)), closes [#239](#239)
@antonbabenko
Copy link
Member

This PR is included in version 4.24.0 🎉

@github-actions
Copy link

github-actions bot commented Nov 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bryantbiggs bryantbiggs bryantbiggs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request: Support prefix on policy name
3 participants
@cvockrodt @antonbabenko @bryantbiggs