fix: Add missing condition role_session_name when assuming a role #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonbabenko
approved these changes
Aug 30, 2023
antonbabenko
pushed a commit
that referenced
this pull request
Aug 30, 2023
### [5.29.1](v5.29.0...v5.29.1) (2023-08-30) ### Bug Fixes * Add missing condition role_session_name when assuming a role ([#418](#418)) ([89d011e](89d011e))
|
This PR is included in version 5.29.1 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For
iam-assumable-rolethe settingrole_requires_session_name = trueis ignored whenrole_requires_mfa = false.Motivation and Context
For the case when MFA is not enforced, the option to set the condition
role_session_namewhen assuming a role is missing. This was probably due to the confusion caused by unnecessary code duplication (two separate policies whether MFA is enabled or not) when the feature was implemented.Breaking Changes
No.
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request