Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Skip retrieving EKS cluster data when not creating the role #436

Merged
merged 4 commits into from
Jan 18, 2024
Merged

fix: Skip retrieving EKS cluster data when not creating the role #436

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fac26e8
Add additional conditional to the data elements
wonko Nov 15, 2023
c83655f
Merge branch 'master' into feature/only-read-cluster-when-creating-role
antonbabenko Jan 17, 2024
0aa3df1
Update modules/iam-eks-role/main.tf
bryantbiggs Jan 18, 2024
d2220a8
Update modules/iam-eks-role/main.tf
bryantbiggs Jan 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions modules/iam-eks-role/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ locals {
}

data "aws_eks_cluster" "main" {
for_each = var.cluster_service_accounts
for_each = { for k, v in var.cluster_service_accounts : k => v if var.create_role }

name = each.key
}
Expand Down Expand Up @@ -37,7 +37,7 @@ data "aws_iam_policy_document" "assume_role_with_oidc" {
}

dynamic "statement" {
for_each = var.cluster_service_accounts
for_each = var.create_role ? var.cluster_service_accounts : {}
bryantbiggs marked this conversation as resolved.
Show resolved Hide resolved

content {
effect = "Allow"
Expand Down