Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow user to change own password when no MFA is present #470

Conversation

wonko
Copy link
Contributor

@wonko wonko commented Mar 25, 2024

Description

This allows a user to change their own password when no MFA is present on the account. This is only needed in once situation: when a new users signs in, and is then forced to choose a new password. The MFA isn't set up at that point, and the changing of the password is blocked.

Motivation and Context

Currently users created with the iam_user and iam_group_with_policies are not able to sign in.

Breaking Changes

Don't think so

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

I tested this manually using a new account

This allows a user to change their own password when no MFA is present on the account. This is only needed in once situation: when a new users signs in, and is then forced to choose a new password. The MFA isn't set up at that point, and the changing of the password is blocked.
@wonko wonko mentioned this pull request Mar 25, 2024
1 task
@wonko wonko changed the title Allow user to change own password when no MFA is present fix: Allow user to change own password when no MFA is present Mar 25, 2024
@bryantbiggs bryantbiggs merged commit ef0056b into terraform-aws-modules:master Mar 25, 2024
35 of 36 checks passed
antonbabenko pushed a commit that referenced this pull request Mar 25, 2024
## [5.37.2](v5.37.1...v5.37.2) (2024-03-25)

### Bug Fixes

* Allow user to change own password when no MFA is present ([#470](#470)) ([ef0056b](ef0056b))
@antonbabenko
Copy link
Member

This PR is included in version 5.37.2 🎉

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Users not able to change password
3 participants