Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow modifying the iam-github-oidc-role subject condition #523

Merged

Conversation

bryantbiggs
Copy link
Member

Description

  • Allow modifying the iam-github-oidc-role subject condition

Motivation and Context

Breaking Changes

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@bryantbiggs bryantbiggs merged commit f2ade86 into terraform-aws-modules:master Oct 4, 2024
34 checks passed
@bryantbiggs bryantbiggs deleted the feat/github-condition branch October 4, 2024 01:26
antonbabenko pushed a commit that referenced this pull request Oct 4, 2024
## [5.45.0](v5.44.2...v5.45.0) (2024-10-04)

### Features

* Allow modifying the `iam-github-oidc-role` subject condition ([#523](#523)) ([f2ade86](f2ade86))
@antonbabenko
Copy link
Member

This PR is included in version 5.45.0 🎉

Copy link

github-actions bot commented Nov 3, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid role when creating iam-github-oidc-role with specific branch for the target action
2 participants