Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add note about pgp_key when create_iam_login_profile is set #69

Merged
merged 2 commits into from
Apr 22, 2020

Conversation

MeNsaaH
Copy link
Contributor

@MeNsaaH MeNsaaH commented Apr 22, 2020

Description

The pgp_key is only required if create_iam_login_profile is set. This should be reflected in README. It addresses the issue #39.

Motivation and Context

Documentation is somehow misleading

Breaking Changes

No

How Has This Been Tested?

@MeNsaaH
Copy link
Contributor Author

MeNsaaH commented Apr 22, 2020

@antonbabenko
Can you check this out?

@antonbabenko antonbabenko changed the title Add pgp key is required if create_iam_login_profile is set to README docs: Add note about pgp_key when create_iam_login_profile is set Apr 22, 2020
@antonbabenko antonbabenko merged commit 6fcf2be into terraform-aws-modules:master Apr 22, 2020
@antonbabenko
Copy link
Member

Thanks, @MeNsaaH !

v2.8.0 has been just released.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants