feat: Added Replication Time Control for Bucket Replication #114
Conversation
antonbabenko
changed the title
Done in the last push. Thanks again. Bests. |
versions.tf
Outdated
| @@ -2,6 +2,6 @@ terraform { | |||
| required_version = ">= 0.13.1" | |||
|
|
|||
| required_providers { | |||
| aws = ">= 3.50" | |||
| aws = ">= 3.64.0" | |||
There was a problem hiding this comment.
| aws = ">= 3.64.0" | |
| aws = ">= 3.64" |
README.md
Outdated
| @@ -1,120 +1,15 @@ | |||
| # AWS S3 bucket Terraform module | |||
There was a problem hiding this comment.
Please revert all these docs changes in README, I will fix the rest of this PR (it is too confusing, I know).
There was a problem hiding this comment.
This has not been done yet.
There was a problem hiding this comment.
Is it possible to explain what's expected this way I can make sure I generate the right documentation ?
I am running terraform-docs 0.13.0 from a docker container locally before pushing.
Sorry for the back and forth.
There was a problem hiding this comment.
In this PR you deleted most of the content of the README. Please revert that one, and then running pre-commit run -a will fix the required part related to Terraform versions (if not, I can fix it for you).
There was a problem hiding this comment.
Oh got it now. Normally this should be fixed in the last push.
|
Thanks a lot @antonbabenko !!! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
This change is about taking into account the recent enhancement of the AWS Terraform Provider which now allows to set S3 Replication Time Control (RTC)
Motivation and Context
Thanks to this enhancement, we will be able to provision S3 Bucket Replication Configurations with SLAs and Metrics on the Replication itself from this terraform module.
It's the reflection on the module of the closure of the following issue : hashicorp/terraform-provider-aws#10974
Breaking Changes
There is no breaking change since I have just added the right attributes on the Replication configuration which are read from user input in the destination block of the replication_configuration attribute.
How Has This Been Tested?
examples/*projectsI have adapted the s3-replication example by adding the right input and I was able to successfully see metrics on the AWS S3 Bucket Console.
There was no need to add any control over user input since AWS API provides meaningful error messages in case user input is wrong :
│ Error: expected replication_configuration.0.rules.0.destination.0.replication_time.0.minutes to be in the range (15 - 15), got 16
│
│ with module.s3_bucket.aws_s3_bucket.this[0],
│ on ../../main.tf line 5, in resource "aws_s3_bucket" "this":
│ 5: resource "aws_s3_bucket" "this" {
│
│ Error: expected replication_configuration.0.rules.0.destination.0.replication_time.0.status to be one of [Enabled Disabled], got yes
│
│ with module.s3_bucket.aws_s3_bucket.this[0],
│ on ../../main.tf line 5, in resource "aws_s3_bucket" "this":
│ 5: resource "aws_s3_bucket" "this" {
│
│ Error: expected replication_configuration.0.rules.0.destination.0.metrics.0.minutes to be in the range (10 - 15), got 16
│
│ with module.s3_bucket.aws_s3_bucket.this[0],
│ on ../../main.tf line 5, in resource "aws_s3_bucket" "this":
│ 5: resource "aws_s3_bucket" "this" {
│
│ Error: expected replication_configuration.0.rules.0.destination.0.metrics.0.status to be one of [Enabled Disabled], got true
│
│ with module.s3_bucket.aws_s3_bucket.this[0],
│ on ../../main.tf line 5, in resource "aws_s3_bucket" "this":
│ 5: resource "aws_s3_bucket" "this" {
│
In this case the module users, will be easily able to correct their input to feed with the right values.
I have also ran pre-commit hooks as per the original pre-commit config file.
Thanks again for your review and feedback.
Bests.