-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate vpc_classic_link #824
Comments
Fyi, since this module is setting |
Thank you @lorengordon for that. While that is rather annoying, I'm leaning towards maybe just setting it to null on the argument here in the module. Some could view that as a breaking change, but since AWS made this decision and that is the direction (and I suspect it affects a very, very small segment of users), I'm inclined in making that change since it seems like the easiest path to resolution with the least disruption. @antonbabenko what do you think about setting Line 27 in 78f2845
null ?
|
You might as well just remove the argument from the resource, in that case... It's the same effect to terraform and the provider and the users, and less code. |
The harder "backwards incompatible" bit for this module, imo, would be the removal of the variable, Certainly, users that are relying on that variable and setting it to Anyway, just my two cents. I always pin module versions and test updates, so I'm happy as long as the deprecation warning goes away. 😛 |
This issue has been resolved in version 3.14.4 🎉 |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Is your request related to a new offering from AWS?
Is this functionality available in the AWS provider for Terraform? See CHANGELOG.md, too.
Is your request related to a problem? Please describe.
Describe the solution you'd like.
Implement a migration path once the classiclink is completely removed from the AWS provider.
Describe alternatives you've considered.
Additional context
Warning shows up since we bumped the AWS provider to 4.28.0.
The text was updated successfully, but these errors were encountered: