fix: Remove EC2-classic deprecation warnings by hardcoding classiclink values to null
#826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k values to `null`
antonbabenko
approved these changes
Sep 5, 2022
| @@ -694,8 +696,9 @@ variable "default_vpc_enable_dns_hostnames" { | |||
| default = false | |||
| } | |||
|
|
|||
| # tflint-ignore: terraform_unused_declarations | |||
antonbabenko
pushed a commit
that referenced
this pull request
Sep 5, 2022
### [3.14.4](v3.14.3...v3.14.4) (2022-09-05) ### Bug Fixes * Remove EC2-classic deprecation warnings by hardcoding classiclink values to `null` ([#826](#826)) ([736931b](736931b))
|
This PR is included in version 3.14.4 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
nullnullas unset value, resulting in deprecation warning hashicorp/terraform#31730 - defaulting tonulldoes not resolve the warning and instead we have to hardcode the value asnullto satisfy. Users cannot create new EC2-classic VPCs today, and users who are still using EC2-classic are required to upgrade (per AWS) - users who are using EC2-classic created under this module should pin their module version to v3.14.3 until they have migrated their VPC out of EC2-classicMotivation and Context
Breaking Changes
tl;dr - the breaking change is on the AWS side, not the module
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request