Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Ability to specify CloudWatch Log group name for VPC Flow logs #836

Closed
air3ijai opened this issue Oct 8, 2022 · 5 comments

Comments

@air3ijai
Copy link
Contributor

air3ijai commented Oct 8, 2022

Is your request related to a problem? Please describe.

As for now, we can specify just flow_log_cloudwatch_log_group_name_prefix and with all defaults we will get a kind of the the following name for CloudWatch Log group name:

/aws/vpc-flow-log/vpc-02b7411f86f26842b

Describe the solution you'd like.

We should be able to specify CloudWatch Log group name(suffix) in order to be able to identify it by name.

A variable like flow_log_cloudwatch_log_group_name = project-name should permit us to set custom name instead of VPC ID:

/aws/vpc-flow-log/project-name

Current code

name = "${var.flow_log_cloudwatch_log_group_name_prefix}${local.vpc_id}"

@bryantbiggs
Copy link
Member

this is not a naming scheme we control - its a naming scheme controlled by AWS that we match here in order to "control" the log group

@air3ijai
Copy link
Contributor Author

air3ijai commented Oct 8, 2022

Not sure if I understand correctly - we cannot do this or we should not do this?

I just updated code to test how it works

  name              = "${var.flow_log_cloudwatch_log_group_name_prefix}projects-name"

Screen Shot 2022-10-08 at 16 24 25

@bryantbiggs
Copy link
Member

I was trying to find the documentation but I stand corrected - I guess we do have control over the log group name. A lot of other services usually dictate the name of the log group but I guess VPC flow logs allows complete control of the name

@antonbabenko
Copy link
Member

Fixed in #847

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants