With zero public subnets, s3 vpc endpoint association fails

[lorengordon]

When passing no public subnets, but still using an S3 VPC endpoint, the module should not try to associate the endpoint with a (non-existent) public route table.

Error: Error running plan: 1 error(s) occurred:

* module.vpc.aws_vpc_endpoint_route_table_association.public_s3: 1 error(s) occurred:

* module.vpc.aws_vpc_endpoint_route_table_association.public_s3: Resource 'aws_route_table.public' not found for variable 'aws_route_table.public.id'

The condition in this line needs to account for the length of var.public_subnets.

Looks like the count for the dynamodb vpc endpoint is also flawed. A bit differently though. There is only one public route table for all public subnets, so the length check should be in the condition and the count should be 1 if true.

[antonbabenko]

Good job, Loren! v1.28.0 has been now released with this fix.

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.