-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for dns_options
on VPC endpoints
#1023
feat: Add support for dns_options
on VPC endpoints
#1023
Conversation
@antonbabenko if you could please review this or tag relavent people to review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would love to see this merged!! Currently blocking a private MWAA deployment because Terraform doesn't support this.
@bryantbiggs |
dns_options
on VPC endpoints
## [5.5.0](v5.4.0...v5.5.0) (2024-01-09) ### Features * Add support for `dns_options` on VPC endpoints ([#1023](#1023)) ([32f853f](32f853f))
This PR is included in version 5.5.0 🎉 |
@bryantbiggs thanks for merging |
Then users should not provide it. Sometimes we can provide the means to help users avoid misconfiguration, but in this scenario the logic would be overly complex |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
add dns_options block to use it in cases of endpoints that support gateway and interface
Motivation and Context
Breaking Changes
How Has This Been Tested?
examples/*
to demonstrate and validate my change(s)examples/*
projectsthere is no user input change, if the array is not existend or private_dns_enabled is false it will not trigger a change
tested locally
pre-commit run -a
on my pull request