Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(nat-gateway): Add nat_gateway_tags_per_az variable for NAT gateways #1140

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pavlospt
Copy link

@pavlospt pavlospt commented Nov 19, 2024

Description

Adding nat_gateway_tags_per_az variable for NAT gateways

Motivation and Context

It is useful for cost related reports to be able to tag NAT gateways per AZ.

Breaking Changes

No

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@pavlospt pavlospt force-pushed the chore/add-nat-gateway-tags-per-az branch from 058dbba to cba7cea Compare November 19, 2024 10:30
@pavlospt
Copy link
Author

@bryantbiggs @antonbabenko Sorry for tagging you directly, but would it be possible to have a review here? 🙏🏻

@bryantbiggs
Copy link
Member

why is this a useful change, what motivates a specific tag per NAT?

@pavlospt
Copy link
Author

pavlospt commented Dec 18, 2024

@bryantbiggs Extremely useful for cost observability reasons (at least in our case, we can know what volume of traffic is going through each of our NATs and correlate that with the workloads living there, by using Cost Reports with Tag dimension).

@bryantbiggs
Copy link
Member

but you know the NAT gateway IDs and can use that to correlate, no? this sounds like a side effect of cross-AZ traffic which I don't see the benefit of taking on such complexity in this module for this peculiar case

@pavlospt
Copy link
Author

By using common tags across resources we can do what I describe above. I am not sure why or how this feature brings the complexity you mention, given that the info we need is already there and we just utilize it.

Indeed it made things pretty clear for us regarding Cross AZ traffic costs. If you have better alternatives to suggest, we would love to investigate them!

@pavlospt pavlospt force-pushed the chore/add-nat-gateway-tags-per-az branch from cba7cea to 8c62508 Compare December 19, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants