Fix *dns* vars description according to AWS Docs #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the delay. I don't know how I managed to skipped this one. Good idea to write things correctly, but let's write it more generic:
via: |
ChairmanTubeAmp
pushed a commit
to Shapeways/terraform-aws-vpc
that referenced
this pull request
Nov 28, 2017
* 'master' of github.com:Shapeways/terraform-aws-vpc: Reverted bad merge, fixed terraform-aws-modules#33 Set enable_dns_support=true by default Updated descriptions for DNS variables (closes terraform-aws-modules#14) Add version requirements in README.md (fixes terraform-aws-modules#32) Add version requirements in README.md make sure outputs are always valid (terraform-aws-modules#29) Add tags to the aws_vpc_dhcp_options resource (terraform-aws-modules#30) Add support for DHCP options set (terraform-aws-modules#20) terraform-aws-modules#22 add vpn gateway feature (terraform-aws-modules#24) Add cidr_block outputs to public and private subnets (terraform-aws-modules#19)
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
waddamski
pushed a commit
to hmrc/terraform-aws-vpc
that referenced
this pull request
Jul 5, 2024
waddamski
pushed a commit
to hmrc/terraform-aws-vpc
that referenced
this pull request
Jul 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a request to fix description of 2 variables. According to the official documentation, dns variables are about public hostnames and the public DNS server(s) of AWS: http://docs.aws.amazon.com/AmazonVPC/latest/UserGuide/vpc-dns.html