Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusted count of NAT gateways to be dependent upon the number of AZs #44

Merged
merged 3 commits into from
May 18, 2017

Conversation

dyindude
Copy link
Contributor

@dyindude dyindude commented Apr 20, 2017

I was using this module for a project that had 9 private subnets and was frustrated when I found I also had 9 NAT gateways.

This change will create one NAT gateway per AZ and the private subnets will end up with routes to the NAT gateway in the same AZ.

This is related to issue #42

@bendavies
Copy link

@antonbabenko any chance of merging this?

@antonbabenko
Copy link
Member

@bendavies I didn't have a chance to try out this PR myself.

If you (or anyone other than code submitter) can maybe try to run this code in your setup and confirm that it works as expected then we can merge it right away.

The reason why I think we need to run code before merging is that there are a lot of people using master branch of this module already and we should not break it for them.

@bendavies
Copy link

@antonbabenko thanks, will do. Will try to get back to you by tomorrow

main.tf Outdated Show resolved Hide resolved
@analytically
Copy link

Any progress on this issue?

@antonbabenko
Copy link
Member

LGTM. I will merge now.

@antonbabenko antonbabenko merged commit 2cbc513 into terraform-community-modules:master May 18, 2017
@antonbabenko
Copy link
Member

Thanks all!

I have just created tag for this release - https://github.com/terraform-community-modules/tf_aws_vpc/releases/tag/v1.0.6

If you want to use the previous version, use this tag - https://github.com/terraform-community-modules/tf_aws_vpc/releases/tag/v1.0.5

@dyindude
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants