Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: Groups creation and permissions #1110

Merged
merged 30 commits into from
Mar 18, 2024
Merged

fix!: Groups creation and permissions #1110

merged 30 commits into from
Mar 18, 2024

Conversation

Samir-Cit
Copy link
Contributor

@Samir-Cit Samir-Cit commented Feb 8, 2024 •
edited by apeabody
Loading

Hello folks.

This PR is to fix the creation and the directions regarding the groups on step 0-bootstrap.
Also it is fixing the roles to the groups on steps 1-org and 2-environments.

Those changes were doing following the official Google documentation on Foundations Groups.

BEGIN_COMMIT_OVERRIDE
fix: Groups creation and permissions (#1110)
END_COMMIT_OVERRIDE

@Samir-Cit Samir-Cit requested review from rjerrems, gtsorbo and a team as code owners February 8, 2024 19:44
romanini-ciandt
romanini-ciandt reviewed Feb 15, 2024
View reviewed changes
1-org/envs/shared/essential_contacts.tf Outdated Show resolved Hide resolved
0-bootstrap/README.md Outdated Show resolved Hide resolved
Samir-Cit
Samir-Cit commented Feb 24, 2024
View reviewed changes
0-bootstrap/variables.tf Outdated Show resolved Hide resolved
helpers/foundation-deployer/stages/data.go Outdated Show resolved Hide resolved
1-org/envs/shared/variables.tf Outdated Show resolved Hide resolved
eeaton
eeaton reviewed Feb 26, 2024
View reviewed changes
1-org/envs/shared/iam.tf Outdated Show resolved Hide resolved
1-org/envs/shared/iam.tf Outdated Show resolved Hide resolved
0-bootstrap/README.md Outdated Show resolved Hide resolved
0-bootstrap/variables.tf Outdated Show resolved Hide resolved
1-org/envs/shared/essential_contacts.tf Outdated Show resolved Hide resolved
0-bootstrap/README.md Outdated Show resolved Hide resolved
0-bootstrap/README.md Outdated Show resolved Hide resolved
eeaton
eeaton approved these changes Feb 29, 2024
View reviewed changes
Copy link
Collaborator

@eeaton eeaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@Samir-Cit
Copy link
Contributor Author

/gcbrun

apeabody
apeabody approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@apeabody apeabody left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by @eeaton, merging

@apeabody apeabody merged commit f57a47c into terraform-google-modules:master Mar 18, 2024
6 checks passed
@release-please release-please bot mentioned this pull request Mar 18, 2024
Merged
fmichaelobrien
fmichaelobrien reviewed Mar 20, 2024
View reviewed changes
Copy link
Contributor

@fmichaelobrien fmichaelobrien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this - I just happen to be rerunning groups creation in a clean org instead of previously using the foundations wizard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romanini-ciandt romanini-ciandt romanini-ciandt left review comments

@fmichaelobrien fmichaelobrien fmichaelobrien left review comments

@apeabody apeabody apeabody approved these changes

@eeaton eeaton eeaton approved these changes

@rjerrems rjerrems Awaiting requested review from rjerrems rjerrems is a code owner

@gtsorbo gtsorbo Awaiting requested review from gtsorbo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Samir-Cit @eeaton @apeabody @fmichaelobrien @romanini-ciandt