-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(master): release 4.1.0 #1074
Conversation
/gcbrun |
43882ac
to
f7569c3
Compare
/gcbrun |
f7569c3
to
00b3fac
Compare
/gcbrun |
00b3fac
to
fc13bf9
Compare
/gcbrun |
fc13bf9
to
4b4cb93
Compare
/gcbrun |
4b4cb93
to
275bbc7
Compare
/gcbrun |
275bbc7
to
4a880a9
Compare
/gcbrun |
4a880a9
to
6201d68
Compare
/gcbrun |
6201d68
to
d89eebc
Compare
/gcbrun |
4b5d762
to
5fd8651
Compare
/gcbrun |
yo is 5.0.0 coming out? |
5fd8651
to
5d1854d
Compare
/gcbrun |
5d1854d
to
f5141da
Compare
/gcbrun |
Hi @kkrastev-cloudoffice, this project uses the release-please bot for tagging major versions, but we're not doing automatic version tag upgrades because we have some waterfall dependencies across other assets. Major architectural changes need coordination with a rewrite of the guide and other assets. There are some significant architectural fixes we'll make in the coming months as part of v5 overhaul, then release a formal v5 tag once those are available. For practical use, the delayed release of version tags shouldn't impact your use because all hotfixes and QOL improvements since v4.0 version in december are available publicly on the main branch. See also intended usage and support: the expectation with this repo is that it will be cloned and forked to your own version, not used as a remote reference, so the tags don't have the intended use of pinning remote versions. Open to feedback if this approach doesn't work for your use case. |
Hi @eeaton I am trying to create a custom LZ for our purposes, based on 4.0.0 and I am having the following issue. I want to deploy locally with terraform and use cloudbuild later. Reading from the dox for 0-bootstrap, it says: Deploying with Cloud Build Where are the local instructions? https://github.com/terraform-google-modules/terraform-example-foundation/blob/master/0-bootstrap/README.md#running-terraform-locally I see nothing here and can't really continue. Currently I don't see how to proceed using this module with cloudbuild or locally. I guess this will be fixed in 5.0.0. I am thinking to just fork the 5.0.0 branch. What do you think? Cheers, |
@kkrastev-cloudoffice , thanks for sharing the context, I think I can help. In this context, "running locally" means running terraform commands from your own workstation, without a remote source repository and without Cloud Build or similar CICD tools. The directions for running locally are contained in each stage. For example after deploying 0-bootstrap, then you would follow the directions in 1-org for running locally. The 0-bootstrap directions for Cloud Build are effectively also local, because at this stage you're running all the terraform commands from your local workstation until the repositories are set up. Go through the same directions related to terraform steps, and ignore step 13 onwards about configuring source repos. If you get an error about enabling the CSR API, remove the offending line from your cloud and try again. It's fair feedback that this isn't clear from the bootstrap directions, I'll add this to the backlog in #1249 to rewrite the default deployment options and guidance. Btw, re: forking the 5.0.0 branch... |
f5141da
to
b9afb4e
Compare
/gcbrun |
b9afb4e
to
c00bcb4
Compare
/gcbrun |
c00bcb4
to
a9313fd
Compare
/gcbrun |
/gcbrun |
We will now make an exception and release a tagged version 4.1.0 based on an internal development use case that needs to pin directions to a known good version and needs some of the fixes introduced in this PR. Going forward, hotfixes and support issues will continue to be merged to main branch and will be available without a tag update. We have some waterfall planning and dependencies for making more significant architectural changes that will be released as v5 next quarter. It is still the intent that users of this blueprint fork it and use it from their own repo, we do not intend to support using this repo as a remote reference (see intended usage and support). |
🤖 Created releases:
|
🤖 I have created a release beep boop
4.1.0 (2024-08-01)
Features
Bug Fixes
This PR was generated with Release Please. See documentation.