Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: '3-networks' minor inconsistencies and typos #304

Merged
merged 2 commits into from
Dec 15, 2020
Merged

fix: '3-networks' minor inconsistencies and typos #304

merged 2 commits into from
Dec 15, 2020

Conversation

vovinacci
Copy link
Contributor

This PR fixes 3-networks minor inconsistencies, typos and copy-pastas.

Closes #294

@vovinacci vovinacci requested review from bharathkkb, rjerrems and a team as code owners December 10, 2020 08:02
@vovinacci
Copy link
Contributor Author

@rjerrems @bharathkkb Integration test failed, checked the test spec - didn't find anything that may have broken by this PR. As I don't have access to cloud build for this project, could you please take a look on what it failed? Much appreciated.

@rjerrems
Copy link
Collaborator

/gcbrun

@rjerrems
Copy link
Collaborator

I had a look and triggered the test again, it looks like we hit a transient issue on both. First was a concurrent operation updating IAM on billing project and second was a clash in terms of project names.

@bharathkkb - Did we modify the prefix already? Is that only on develop?

For now I have triggered another test run

@vovinacci
Copy link
Contributor Author

@rjerrems Thanks much! Seems to be fine now.

@@ -105,7 +105,7 @@ module "restricted_shared_vpc" {
}

/******************************************
Base shared VPC
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should stay as Base as per page 30 of the security foundation guide here https://services.google.com/fh/files/misc/google-cloud-security-foundations-guide.pdf

@rjerrems
Copy link
Collaborator

Thanks @vovinacci - I have one small nit for a comment, but once that's fixed it LGTM

@vovinacci
Copy link
Contributor Author

@rjerrems Thanks a lot for the review. Reverted back to Base, also amended for other environments, so the naming is consistent.

Copy link
Collaborator

@rjerrems rjerrems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bharathkkb FYI

@rjerrems rjerrems merged commit f87ed16 into terraform-google-modules:master Dec 15, 2020
@vovinacci vovinacci deleted the fix/3-network-inconsistencies branch December 15, 2020 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minor '3-networks' inconsistencies
2 participants