-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: '3-networks' minor inconsistencies and typos #304
fix: '3-networks' minor inconsistencies and typos #304
Conversation
@rjerrems @bharathkkb Integration test failed, checked the test spec - didn't find anything that may have broken by this PR. As I don't have access to cloud build for this project, could you please take a look on what it failed? Much appreciated. |
/gcbrun |
I had a look and triggered the test again, it looks like we hit a transient issue on both. First was a concurrent operation updating IAM on billing project and second was a clash in terms of project names. @bharathkkb - Did we modify the prefix already? Is that only on develop? For now I have triggered another test run |
@rjerrems Thanks much! Seems to be fine now. |
3-networks/envs/development/main.tf
Outdated
@@ -105,7 +105,7 @@ module "restricted_shared_vpc" { | |||
} | |||
|
|||
/****************************************** | |||
Base shared VPC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should stay as Base as per page 30 of the security foundation guide here https://services.google.com/fh/files/misc/google-cloud-security-foundations-guide.pdf
Thanks @vovinacci - I have one small nit for a comment, but once that's fixed it LGTM |
@rjerrems Thanks a lot for the review. Reverted back to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@bharathkkb FYI
This PR fixes
3-networks
minor inconsistencies, typos and copy-pastas.Closes #294