-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): consolidate renovate bot dependency fixes #1251
chore(deps): consolidate renovate bot dependency fixes #1251
Conversation
…ntrols/google to v6
…tools' into renovatebot-combined
…les-cloud-storage-google-6.x' into renovatebot-combined
…les-vpc-service-controls-google-6.x' into renovatebot-combined
…les-vm-google-11.x' into renovatebot-combined
…-center-8.x' into renovatebot-combined
@apeabody Can you approve this when you have a chance please? |
…owed_action" argument. (11.0 treats it as required, but should be optional)
…ules/terraform-google-vm#406 No functional change: leaving most_disruptive_allowed_action blank by default should be equivalent to "REPLACE"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - The only downside is if there is an issue it can be more difficult to pinpoint which update is the source.
/gcbrun |
@apeabody @eeaton
to add the
to fix
and usage of Maybe from
to
|
…ck (same behavior as already present in ingressPolicies)
Thanks for the guidance Daniel. I've made an additional commit to the tests on this PR and raised the upstream fix as well terraform-google-modules/terraform-google-vpc-service-controls#146 |
thanks team for the update, I'll add this consolidated module update to a scheduled upstream sync for monday. I agree there may be issues with backtracking regressions - however it is also good to have an effective consolidated minor release out at once so a full clean org deploy to 5-app-infra can be done once. The reduce toil option is appreciated. |
Combine the outstanding PR from renovate[bot] into a single PR to reduce toil for release shepherding