-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade module version to allow Terraform Google provider v6 #1350
feat: upgrade module version to allow Terraform Google provider v6 #1350
Conversation
@apeabody @bharathkkb Could you PTAL? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @daniel-cit! One question, otherwise this LGTM
Co-authored-by: Andrew Peabody <andrewpeabody@google.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @daniel-cit!
Looks like another
|
build failed because field This will require a change in the bootstrap module to fix |
@daniel-cit Surprising that was added in a non-major version, could also pin this to |
I have set the version constraint with |
Upgrade module version to allow Terraform Google provider v6
complete upgrade of 1-org depends on cloud function module that depends on cloud run module. They can be integrated later.
includes the creation of new inputs for
project_deletion_policy
andfolder_deletion_protection