fix!: Fix for hierarchical firewall policy #1354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renato-rudnicki
requested review from
rjerrems,
gtsorbo,
eeaton,
sleighton2022 and
a team
as code owners
renato-rudnicki
changed the title
daniel-cit
changed the title
apeabody
reviewed
Dec 18, 2024
| @@ -1,5 +1,5 @@ | |||
| /** | |||
| * Copyright 2022 Google LLC | |||
| * Copyright 2021 Google LLC | |||
There was a problem hiding this comment.
Is there a reason for this change?
There was a problem hiding this comment.
No reason, Probably a mistake. Fixing.
|
Thanks @renato-rudnicki - I suspect we also need to update the minimum version constraints:
For example |
apeabody
reviewed
Dec 18, 2024
apeabody
approved these changes
Dec 19, 2024
There was a problem hiding this comment.
Thanks @renato-rudnicki! LGTM, just waiting on the CI to go green
CC: @amandakarina
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API resources used by
3-networks-dual-svpc/modules/hierarchical_firewall_policyand3-networks-hub-and-spoke/modules/hierarchical_firewall_policyare deprecated and causing deployment failures on Foundation. This pull request addresses the issue by updating the resources to their latest versions.Issue related: hashicorp/terraform-provider-google#20657