Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds peering example #243

Conversation

amandakarina
Copy link
Contributor

Hey folks,

This pull request adds peering example for step 4-projects.

Could you please, take a look?

Thanks!

@rjerrems
Copy link
Collaborator

FYI it looks like tests are failing due to peering occurring concurrently ``` Error: Error adding network peering: googleapi: Error 400: There is a peering operation in progress on the local or peer network. Try again later., badRequest

     on .terraform/modules/projects_bu1_dev.peering/modules/network-peering/main.tf line 22, in resource "google_compute_network_peering" "local_network_peering":
     22: resource "google_compute_network_peering" "local_network_peering" {
   
   
   
   Error: Error adding network peering: googleapi: Error 400: There is a peering operation in progress on the local or peer network. Try again later., badRequest
   
     on .terraform/modules/projects_bu1_prod.peering/modules/network-peering/main.tf line 22, in resource "google_compute_network_peering" "local_network_peering":
     22: resource "google_compute_network_peering" "local_network_peering" {```

@amandakarina amandakarina marked this pull request as ready for review September 24, 2020 16:02
@amandakarina amandakarina requested a review from a team as a code owner September 24, 2020 16:02
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and thanks for adding the tests @amandakarina
/cc @rjerrems

Copy link
Collaborator

@rjerrems rjerrems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rjerrems rjerrems merged commit dc6dd95 into terraform-google-modules:master Sep 29, 2020
bharathkkb pushed a commit that referenced this pull request Feb 11, 2021
Hi All, this PR updates the main readme to include the new network peering projects from  #243.
bharathkkb pushed a commit that referenced this pull request Mar 30, 2021
Hi All, this PR updates the main readme to include the new network peering projects from  #243.
bharathkkb pushed a commit that referenced this pull request Mar 30, 2021
Hi All, this PR updates the main readme to include the new network peering projects from  #243.
bharathkkb pushed a commit that referenced this pull request Mar 30, 2021
Hi All, this PR updates the main readme to include the new network peering projects from  #243.
bharathkkb pushed a commit that referenced this pull request Mar 31, 2021
Hi All, this PR updates the main readme to include the new network peering projects from  #243.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants