Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use f1-micro as the machine type for the deploy in 5-app-infra step #416

Merged
merged 2 commits into from
Apr 10, 2021
Merged

use f1-micro as the machine type for the deploy in 5-app-infra step #416

merged 2 commits into from
Apr 10, 2021

Conversation

daniel-cit
Copy link
Contributor

Fixes #415

@daniel-cit daniel-cit requested review from bharathkkb, rjerrems and a team as code owners April 10, 2021 01:44
@bharathkkb
Copy link
Member

@daniel-cit we need to update tests as well

terraform-example-foundation/test/integration/app-infra/controls/gcp_projects.rb

Line 33 in 141c059

its('machine_type') { should match 'n1-standard-1' }

@daniel-cit
Copy link
Contributor Author

@bharathkkb tests fixed :)

@bharathkkb bharathkkb merged commit 1fad10b into terraform-google-modules:master Apr 10, 2021
@daniel-cit daniel-cit deleted the use-small-machine-type branch May 20, 2022 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharathkkb bharathkkb bharathkkb approved these changes

@rjerrems rjerrems Awaiting requested review from rjerrems rjerrems is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VMs create in step 5-app-infra should use a smaller Machine type
2 participants
@daniel-cit @bharathkkb