Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix source repos keys in sa_roles map #895

Conversation

felipecrescencio-cit
Copy link
Contributor

Fix source repos to allow user to create as many applications workspaces as user needs and just provide the roles (sa_roles) to user applications.
Previous to this fix user will need to provide each repo key for all applications in sa_roles map.

@felipecrescencio-cit felipecrescencio-cit requested review from a team and rjerrems as code owners December 1, 2022 23:38
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @felipecrescencio-cit
I did not fully understand what you meant by Previous to this fix user will need to provide each repo key for all applications in sa_roles map.. Could you clarify the usecase?

Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Synced offline. This is due to the fact that app_infra_pipeline_service_accounts keys could have more than one repo which may not be present in the sa_roles map leading to a error when looking up var.sa_roles[{local.source_repos.value}].

@bharathkkb bharathkkb merged commit 8bd7d14 into terraform-google-modules:master Dec 7, 2022
@felipecrescencio-cit felipecrescencio-cit deleted the fix-source-repos-multiple-apps branch December 7, 2022 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants