Stackdriver Export to Datadog v2 #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@morgante Do you have some time this afternoon to chat? I'm not sure why this is failing (still no logs access) and my test setup seems irreparably tanked. UPDATE: I have log access, but it looks like the tests are failing on the prepare step with an IAM error. |
|
Sure, we can look at it together this afternoon. |
new file: examples/datadog-sink/main.tf new file: examples/datadog-sink/outputs.tf new file: examples/datadog-sink/screenshots/Screen Shot 2019-12-09 at 4.44.11 PM.png new file: examples/datadog-sink/terraform.tfvars.sample new file: examples/datadog-sink/variables.tf new file: examples/datadog-sink/versions.tf modified: modules/pubsub/README.md modified: modules/pubsub/main.tf modified: modules/pubsub/outputs.tf modified: modules/pubsub/variables.tf modified: modules/pubsub/versions.tf
morgante
approved these changes
Dec 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to rebase and squash but it was becoming tedious and there were enough commits that I just reset my fork back to the upstream master and added the files I needed from a backup. Certainly not best practice, but I'm tired of fighting with git and hopefully this works.